Add MultipartRequest log to CurlInterceptor #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephNK
requested review from
JEuler,
lejard-h,
meysam1717,
pingbird,
stewemetal and
techouse
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #435 +/- ##
===========================================
+ Coverage 93.65% 93.75% +0.09%
===========================================
Files 8 8
Lines 441 448 +7
===========================================
+ Hits 413 420 +7
Misses 28 28
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Would you mind please adding some tests for this? |
|
How can I do it? |
|
Check these out and make some similar test cases covering them. You can run them using |
techouse
approved these changes
May 27, 2023
Merged
techouse
added a commit
that referenced
this pull request
May 28, 2023
# chopper ## 6.1.3 * Add follow redirects to toHttpRequest (#430) * Update http constraint to ">=0.13.0 <2.0.0" (#431) * Add MultipartRequest log to CurlInterceptor (#435) --- # chopper_built_value ## 1.2.2 * Update http constraint to ">=0.13.0 <2.0.0" (#431) --- # example * Update squadron example (#432) --- # Github actions * Add cleanup step to publish workflow (#434) --------- Co-authored-by: Joran Dob <joran998@gmail.com> Co-authored-by: Joseph, NamKung <nkw0608@gmail.com> Co-authored-by: Klemen Tusar <techouse@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using CurlInterceptor, the log output for MultipartRequest was missing. So, I added the Log of MultipartRequest. :)