Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ implement Dart 3 class modifiers #453

Merged
merged 7 commits into from
Jul 29, 2023

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Jul 29, 2023

  • bump minimum Dart SDK version to 3.0.0
  • bump dependencies to the latest (except analyzer)
  • implement Dart 3 class modifiers
  • bump all package major versions:
    • chopper: 7.0.0
    • chopper_generator: 7.0.0
    • chopper_built_value: 2.0.0

@techouse techouse added the enhancement New feature or request label Jul 29, 2023
@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #453 (184e48e) into develop (96f9dbc) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #453      +/-   ##
===========================================
- Coverage    93.80%   93.79%   -0.02%     
===========================================
  Files            8        8              
  Lines          452      451       -1     
===========================================
- Hits           424      423       -1     
  Misses          28       28              
Files Changed Coverage Δ
chopper/lib/src/base.dart 94.69% <ø> (-0.04%) ⬇️
chopper/lib/src/interceptor.dart 76.11% <ø> (ø)
chopper/lib/src/request.dart 100.00% <ø> (ø)
chopper/lib/src/response.dart 88.88% <ø> (ø)
chopper/lib/src/utils.dart 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@techouse techouse changed the title ✨ implement Dart 3 language features ✨ implement Dart 3 class modifiers Jul 29, 2023
@techouse techouse marked this pull request as ready for review July 29, 2023 13:30
@techouse
Copy link
Collaborator Author

@JEuler I have added class modifiers to make class inheritance more strict where I thought it necessary. Let me know your thoughts.

@JEuler
Copy link
Collaborator

JEuler commented Jul 29, 2023

What do you think about sdk: ">=3.0.0 <4.0.0"? That is a big thing as I understand. Personally I don't have problems with that already, but maybe for someone that will be a problem.

Any way, we should make it major then. :)

@techouse
Copy link
Collaborator Author

What do you think about sdk: ">=3.0.0 <4.0.0"?

Class modifiers are a Dart 3 thing. Dart 2 doesn't support them.

Any way, we should make it major then. :)

Yep.

  • chopper: 7.0.0
  • chopper_generator: 7.0.0
  • chopper_built_value: 2.0.0

@JEuler
Copy link
Collaborator

JEuler commented Jul 29, 2023

Yeah, I know about the Dart 2-3. That's cool then, thank you!

@techouse techouse merged commit 6afebb0 into lejard-h:develop Jul 29, 2023
7 checks passed
@techouse techouse deleted the chore/dart-3 branch July 29, 2023 16:17
@techouse techouse mentioned this pull request Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants