Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add final class modifier to generated Chopper API implementation #463

Merged

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Aug 2, 2023

This PR adds the final class modifier to the generated Chopper API implementation, i.e.

before

class _$MyService extends MyService {
  _$MyService([ChopperClient? client]) {
    if (client == null) return;
    this.client = client;
  }
  
  // ... stuff
}

after

final class _$MyService extends MyService {
  _$MyService([ChopperClient? client]) {
    if (client == null) return;
    this.client = client;
  }
  
  // ... stuff
}

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #463 (c6774e6) into develop (7a6b5b9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #463   +/-   ##
========================================
  Coverage    93.70%   93.70%           
========================================
  Files            8        8           
  Lines          445      445           
========================================
  Hits           417      417           
  Misses          28       28           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@techouse techouse merged commit e9fc26d into lejard-h:develop Aug 3, 2023
@techouse techouse deleted the feat/final-chopper-api-implementation branch August 3, 2023 05:50
@techouse techouse added the enhancement New feature or request label Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants