Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 export ChopperLogRecord to library surface #480

Merged
merged 1 commit into from
Aug 14, 2023
Merged

🩹 export ChopperLogRecord to library surface #480

merged 1 commit into from
Aug 14, 2023

Conversation

Maxr1998
Copy link
Contributor

@Maxr1998 Maxr1998 commented Aug 13, 2023

Forgot to do this is my last PR.

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #480 (1d8030d) into develop (764d57d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #480   +/-   ##
========================================
  Coverage    93.83%   93.83%           
========================================
  Files            9        9           
  Lines          454      454           
========================================
  Hits           426      426           
  Misses          28       28           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@techouse
Copy link
Collaborator

techouse commented Aug 13, 2023

LGTM

As a side note, you could make ChopperLogRecord final or base, i.e.

final class ChopperLogRecord {
  const ChopperLogRecord(this.message, {this.request, this.response});

  final String message;
  final Request? request;
  final Response? response;

  @override
  String toString() => message;
}

as I do not believe that it should be extended nor implemented outside the library, unless I am mistaken.

@Maxr1998
Copy link
Contributor Author

I think final is good. Opened #481 for that change since it's not directly related to this one.

@techouse techouse merged commit f8905ad into lejard-h:develop Aug 14, 2023
6 checks passed
@techouse techouse mentioned this pull request Aug 14, 2023
@Maxr1998 Maxr1998 deleted the expose-log-record branch August 14, 2023 10:00
@techouse techouse self-assigned this Aug 22, 2023
@techouse techouse added the enhancement New feature or request label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants