Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix chopper_built_value pub.dev topics #498

Merged
merged 3 commits into from
Sep 2, 2023

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Sep 2, 2023

Fixes

Invalid `topics` value (`built_value`): must consist of lowercase alphanumerical characters or dash (but no double dash), starting with a-z and ending with a-z or 0-9.

Looks like the topic built_value has to be renamed to built-value 😒 Odd that dart pub publish --dry-run didn't catch it.

To prevent this in the future, I've added a step into both the publish.yml and publish_dry_run.yml workflows:

- name: Validate pub.dev topics
  id: validate_pub_dev_topics
  run: |
    set -e
    pushd ${{ matrix.package }} || exit
    pattern="^[a-z][a-z0-9-]*[a-z0-9]$"
    for topic in $(yq -r '.topics[]' pubspec.yaml); do
      if [[ ! $topic =~ $pattern ]]; then
        echo "Invalid topic: $topic"
        exit 1
      fi
    done
    popd || exit

@techouse techouse added bug Something isn't working documentation Documentation related labels Sep 2, 2023
@techouse techouse removed the documentation Documentation related label Sep 2, 2023
@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #498 (e83c6a9) into master (7833e70) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #498   +/-   ##
=======================================
  Coverage   93.87%   93.87%           
=======================================
  Files           9        9           
  Lines         457      457           
=======================================
  Hits          429      429           
  Misses         28       28           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@techouse techouse merged commit b969ea0 into master Sep 2, 2023
12 checks passed
@techouse techouse deleted the fix/fix-chopper-built-value-pub-topic branch September 2, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants