Fix incorrect url generation when using new baseurl #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinale14
requested review from
JEuler,
lejard-h,
meysam1717,
stewemetal and
techouse
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #520 +/- ##
========================================
Coverage 93.95% 93.95%
========================================
Files 9 9
Lines 463 463
========================================
Hits 435 435
Misses 28 28 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
techouse
changed the title
techouse
requested changes
Oct 12, 2023
techouse
reviewed
Oct 12, 2023
techouse
approved these changes
Oct 12, 2023
|
I'll make a release later in the evening. |
techouse
added a commit
that referenced
this pull request
Oct 12, 2023
# chopper_generator ## 7.0.6 - #520
|
@martinale14 ^^ released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrite the replaceallMethod that removes double
//making it follow a regular expresion that ignoreshttp://andhttps://on the replacementAddresses #519