Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mock mixins of Chopper components. #529

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

diegotori
Copy link
Contributor

Addresses Issue #528.

A variation of PR #479 that isn't opinionated about any particular mocking framework.

@techouse
Copy link
Collaborator

Hey!

I haven't thought about alternative mocking libraries. If that's the case and it works for you, then sure. Can you just fix the formatting errors please 🙏 😊

@diegotori
Copy link
Contributor Author

@techouse sure thing. I'll get to it later today.

@techouse techouse self-assigned this Oct 26, 2023
@techouse techouse added the enhancement New feature or request label Oct 26, 2023
@diegotori
Copy link
Contributor Author

@techouse fixed. Please try running the workflow again.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #529 (fc86771) into develop (f061355) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #529   +/-   ##
========================================
  Coverage    93.95%   93.95%           
========================================
  Files            9        9           
  Lines          463      463           
========================================
  Hits           435      435           
  Misses          28       28           
Files Coverage Δ
chopper/lib/src/base.dart 94.65% <ø> (ø)
chopper/lib/src/chopper_log_record.dart 100.00% <ø> (ø)
chopper/lib/src/request.dart 100.00% <ø> (ø)
chopper/lib/src/response.dart 88.88% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@techouse techouse merged commit e5417d1 into lejard-h:develop Oct 26, 2023
6 checks passed
@diegotori diegotori deleted the add_mocks branch October 26, 2023 19:10
techouse added a commit that referenced this pull request Oct 29, 2023
# chopper

## 7.0.9

- #527
- #529
techouse added a commit that referenced this pull request Oct 30, 2023
# chopper

## 7.0.9

- #527
- #529

---------

Co-authored-by: Diego Tori <diegotoridoesandroid@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants