Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix null body converter #623

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

Guldem
Copy link
Contributor

@Guldem Guldem commented Jun 25, 2024

Fixed #622

Copy link
Collaborator

@techouse techouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.02%. Comparing base (3482cc6) to head (bfd1230).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #623      +/-   ##
===========================================
- Coverage    93.05%   93.02%   -0.03%     
===========================================
  Files           22       22              
  Lines          504      502       -2     
===========================================
- Hits           469      467       -2     
  Misses          35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Guldem
Copy link
Contributor Author

Guldem commented Jun 25, 2024

Not sure what codecov is complaining about?

@techouse
Copy link
Collaborator

Not sure what codecov is complaining about?

-0.03% 😂

@techouse techouse merged commit 627ff1d into lejard-h:develop Jun 25, 2024
5 of 6 checks passed
@techouse techouse mentioned this pull request Jun 26, 2024
@techouse techouse assigned techouse and Guldem and unassigned techouse Jun 27, 2024
@techouse techouse added the bug Something isn't working label Jun 27, 2024
techouse added a commit that referenced this pull request Jun 30, 2024
* ⬆️ update dependencies and linters (#615)

* 📝 update build_runner reference in readme (#616)

* 📄 create symlink to chopper/LICENSE (#617)

* 👥 update/fix contributors (#618)

* 🔒 add Security Policy (#619)

* 🐛 Fix null body converter (#623)

* 📦 directly export `qs.ListFormat` instead of internal wrapper (#624)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Job Guldemeester <job@dutchcodingcompany.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResponseConverterInterceptor overrides null body
2 participants