Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 remove duplicate null-coalescing responseTypeReference #634

Merged
merged 1 commit into from
Aug 30, 2024
Merged

🎨 remove duplicate null-coalescing responseTypeReference #634

merged 1 commit into from
Aug 30, 2024

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Aug 29, 2024 •
edited
Loading

While looking at the generator I found a duplicate null-coalescing responseTypeReference. Probably left there by mistake. It's not a bug per-se, it just looks up the response type 2x for no reason.

CC/ @Guldem

@techouse techouse added the bug Something isn't working label Aug 29, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (33372bf) to head (7ace2dd).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #634   +/-   ##
========================================
  Coverage    93.38%   93.38%           
========================================
  Files           21       21           
  Lines          499      499           
========================================
  Hits           466      466           
  Misses          33       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Guldem
Guldem approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@Guldem Guldem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small woepsie :)

@techouse techouse merged commit 7a1f7c2 into develop Aug 30, 2024
6 checks passed
@techouse techouse deleted the chore/chopper-generator-cleanup branch August 30, 2024 06:37
techouse added a commit that referenced this pull request Sep 5, 2024
@techouse
🔖 release v8.0.2
1d0c732 
# chopper

- #635

# chopper_generator

- #634
@techouse techouse mentioned this pull request Sep 5, 2024
Merged
techouse added a commit that referenced this pull request Sep 5, 2024
@techouse
🔖 release v8.0.2 (#637)
b58a090 
- 🐛 properly escape single quote in cURL interceptor output #635
- 🎨 remove duplicate null-coalescing responseTypeReference #634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guldem Guldem Guldem approved these changes

@JEuler JEuler JEuler approved these changes

@lejard-h lejard-h Awaiting requested review from lejard-h lejard-h is a code owner

@meysam1717 meysam1717 Awaiting requested review from meysam1717 meysam1717 is a code owner

@stewemetal stewemetal Awaiting requested review from stewemetal stewemetal is a code owner

Assignees

@JEuler JEuler

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@techouse @JEuler @Guldem