Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pylint version in an attempt to prevent future spontaneous breakage of CI tests #891

Merged
merged 3 commits into from
Feb 24, 2021

Conversation

dairiki
Copy link
Contributor

@dairiki dairiki commented Feb 23, 2021

Issue(s) Resolved

The release of pylint==2.7.0 caused the CI tests to spontaneously start failing.

References:

Related Issues / Links

There are multiple outstanding PRs which are currently failing CI tests due to no fault of their own.

Description of Changes

Fixed the new warnings ("inconsistent-return-statements").

Pinned the version of pylint used for CI tests to 2.7.0.

@dairiki dairiki marked this pull request as ready for review February 23, 2021 22:39
Copy link
Contributor

@yagebu yagebu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yagebu yagebu merged commit 899b67c into lektor:master Feb 24, 2021
@dairiki dairiki deleted the bug.pylint branch February 24, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants