Support new UIManager API #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XeroX
added a commit
to sweatco/lottie-react-native
that referenced
this pull request
Apr 13, 2019
Patch contains fix from lelandrichardson/react-native-safe-module#6 which adds support for new UIManager API.
XeroX
added a commit
to sweatco/lottie-react-native
that referenced
this pull request
Apr 15, 2019
Patch contains fix from lelandrichardson/react-native-safe-module#6 which adds support for new UIManager API.
|
Any update on this PR? 🙏 |
|
It looks like this is a stale project so this PR will be never merged. I published a fork of it including this PR: https://github.com/emilioicai/react-native-safe-modules |
|
Thanks @emilioicai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this commit got merged in RN 0.58 any direct access to
UIManageris now yielding a deprecation warning.This PR adds support for the new API and provides a fallback for RN < 0.58.
I've decided against tests here since we are using
react-native-mockand mocking mocks is uncool.