Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SEQUENCE NAME in create_seq_stmt_def_elem #151

Merged

Conversation

orages
Copy link

@orages orages commented Aug 1, 2024

While experimenting with pglast v6.2 I found a bug in the printer for a statement like :

ALTER TABLE sch3ma.t1 ALTER COLUMN c1 ADD GENERATED BY DEFAULT AS IDENTITY (SEQUENCE_NAME sch3ma.t1 START WITH 1 INCREMENT BY 1 NO MINVALUE NO MAXVALUE CACHE 1)

which was improperly rendered :

ALTER TABLE sch3ma.t1 ALTER COLUMN c1 ADD GENERATED BY DEFAULT AS IDENTITY (SEQUENCE_NAME (<String sval='sch3ma'>, <String sval='t1'>) START WITH 1 INCREMENT BY 1 NO MINVALUE NO MAXVALUE CACHE 1)

@lelit
Copy link
Owner

lelit commented Aug 1, 2024

Good catch, thank you!

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.54%. Comparing base (f2a7d4e) to head (97a4d28).
Report is 7 commits behind head on v6.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##               v6     #151   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          22       22           
  Lines        6862     6865    +3     
=======================================
+ Hits         6831     6834    +3     
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lelit lelit merged commit 6b8e373 into lelit:v6 Aug 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants