Instantiate new AccessToken when calling AccessToken.create
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `AccessToken` object created with `create` was actually a singleton that was being used as an instanciated object. This could allow multiple token refreshes that happen at the same time to hand back an oauth key for another user. This change should fix the issue.
|
@jonathansamines this fixes a CRITICAL SECURITY ISSUE that allows users of this library to pass back authentication tokens of a single user to multiple callers. |
|
Hi @johnhaley81 sorry for the late response. Would you mind to reopen this PR to develop? I only can make a new release (along with other changes) from that point ;) |
|
@jonathansamines Done! #92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #88