Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display error when cookies are disabled and login is attempted #83

Open
lemeryfertitta opened this issue Aug 27, 2024 · 0 comments
Open
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@lemeryfertitta
Copy link
Owner

The login feature currently uses cookies to store the token, so when cookies are disabled logging in does not work, but it fails silently. Better to show an error that explicitly states cookies must be enabled to use the logged in functionality. Ideally, this can happen when the user clicks the login button to avoid even showing the modal. One easy way to see if cookies are enabled is to write to a test cookie, check its value to see if the write worked, then cleanup the cookie if so.

@lemeryfertitta lemeryfertitta added bug Something isn't working good first issue Good for newcomers labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant