Tick Climbs and Show Stats #72
Conversation
- combined menu on results.view - tick modal draft - added attempts to results.view
This reverts commit 531419b.
css fixed and disable button to prevent multiple submissions
Remove attempts from the log modal
wrong div-class for bootstrap dropdown
removed climbdex.why.dev settings
There was a problem hiding this comment.
Awesome! I played with this briefly but generally seems like a really awesome feature addition. Had some minor comments on the functionality with my quick test drive, but mostly looking good to me. I'll spend a bit more time playing around with it before we get it merged. Just a few comments on code quality items, and obviously we need to get the boardlib updates in first, but would be happy to get this merged and deployed soon!
Thanks @gardaholm!
|
updated |
using bid_count instead of attempt_id to log attempts. updated view.py to handle login in via user_id/token only
| @@ -9,7 +9,9 @@ function drawClimb( | |||
| frames, | |||
There was a problem hiding this comment.
I tried updating boardlib to 0.7.1 and running this PR locally. There were a number of things that were broken for me:
- Upon successful login there is no indication of success (the login text doesn't change) and climbs don't appear to be ticked. Seemed like logging in was generally broken, but I didn't see any error messages in the console or logs.
- Board image is overflowing, at least for Kilter 8x12
Let me know if you are experiencing the same or if I'm doing something wrong!
There was a problem hiding this comment.
strange, didn't happen on our tests here, but I will spin up our test version on fly.io with the official boardlib 0.7.1 and will check it. will probably be able to do it tomorrow morning. sorry for that!
There was a problem hiding this comment.
are you sure it installed the new requirements?
I've spinned a fly.io version here https://climbdex-wandering-moon-444.fly.dev/ (linked to boardlib 0.7.1)
and it seems to work for me …
- tested kilter + tension board with my aurora credentials
- I could login, and get the different status message (You're logged in!)
- can see my ticked and tried climbs (green + yellow)
- could log my climb (logged climbs only get displayed after a full refresh, when the logbook is renewed), also get the Successfull Tick Message.
- the problem with the kilter and tension board classic layout can be fixed via css (will add a commit, seems to be a overflow problemon certain screen dimensions)
There was a problem hiding this comment.
Ah, I found the issue. The local deployment bind I was running on 0.0.0.0:8000 (was doing it for some mobile testing) didn't allow the cookie to be stored, so it just silently was trying and failing to set the cookie. Created #83 for that, as it's pretty confusing why the login doesn't work if your cookies aren't enabled, but it is unrelated to your PR here. As an aside, I figured out how to close the modal without refreshing the whole page (your location.reload change), but I'll just update that in a separate PR.
I think the only thing that is a regression from this PR is the overflow issue. I think its just some issue with the bootstrap containers that were changed to add the new buttons and such.
Also, I just played with the tick feature a little bit more and had a few additional thoughts:
-
Ticking repeats is a little bit weird, it looks identical to trying the climb over multiple sessions and only sending once vs. sending in multiple sessions. I wonder if we shouldn't be trying to aggregate here, and we should just show a list of sessions for each climb. So basically this would just be the list of all of the logbook entries from boardlib for a specific climb
-
Maybe we can rename "Statistics" to "Your Attempts" or something similar. I feel like when you click statistics you expect to get the same information as the info button on the official apps, which shows other peoples ticks and grade distribution chart and such.
We can leave 1. as is for now and change that in a future PR, I think it's worth just getting the current functionality in. Let's get the overflow issue fixed and rename the menu item for this PR.
There was a problem hiding this comment.
I think the only thing that is a regression from this PR is the overflow issue. I think its just some issue with the bootstrap containers that were changed to add the new buttons and such.
should be fixed. I think the occurence is pretty rare >> probably 13'' notebooks + board images which are very long.
Also, I just played with the tick feature a little bit more and had a few additional thoughts:
- Ticking repeats is a little bit weird, it looks identical to trying the climb over multiple sessions and only sending once vs. sending in multiple sessions. I wonder if we shouldn't be trying to aggregate here, and we should just show a list of sessions for each climb. So basically this would just be the list of all of the logbook entries from boardlib for a specific climb
true. I was thinking about the same: if you open the log item a small indication about the sessions would be great and if there are already sessions logged then the flash button can be hidden (I already ran into this issue a few times and wondering why the app don't show the flash icon …). Information is already there so I guess it shouldn't be too much work for a future PR.
What this PR is also missing is a indication that the current climb is logged (besided the success message). It would be nice if the entry in the result list gets the background color and the tick icon after saving the modal. Shouldn't be too hard, maybe I can do this in another PR, it's more a cosmetical thing I guess …
- Maybe we can rename "Statistics" to "Your Attempts" or something similar. I feel like when you click statistics you expect to get the same information as the info button on the official apps, which shows other peoples ticks and grade distribution chart and such.
also fine, renamed the entries (Menu + Modal-Title).
Would love to have the stats. grad distribution and comment also somewhere in climbdex. but probably something for later.
There was a problem hiding this comment.
should be fixed. I think the occurence is pretty rare >> probably 13'' notebooks + board images which are very long.
Didn't really like the overflow approach so I changed it back to the original behavior to scale based on viewport. Also made a few other minor changes to some of the nomenclature but will get this merged and deployed now! Lots of other improvements to make but its a huge start 😄
fixed overflow for #div-climb on results and create-climb page.
renamed menu item and modal title
mistakenly removed id="div-climb" in the previous commit. added it back as before …
|
Thanks for the merge and your work! Hope its a good first addition for the save dialog and we could save you at least some time :) |
This PR addresses #46, #54, #55 and #73
For testing I've put this branch online on fly.to: climbdex.why.dev
Menu Elements and Result View
Dropdown / Hamburger Menu is shown to clean up the Result view a bit. If user is logged in there is an option to logout, tick climb and show stats. If user user is not logged in there is only the beta information available.
Result List marks Sends in green and Attempts in yellow, to give a quick information about the status of the climb.
Simple Climbing and Attempt Stats
If the user is logged in, a separate menu item for Statistics is shown. This modal shows amount of attempts and sessions and when the last session was in a very basic form. I guess this place could be used for further improvements like suggested in Issue #28
Tick Modal
Ticking climbs can be done via the new modal, which should be way faster than compared to the aurora app. Ticking a Climb is done via the boardlib function save_ascent. Difficulty is prefilled but can be changed. Number of attempts can be set when the slider is set to Send instead of Flash.