Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x86 build with msvc compiler #112

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix x86 build with msvc compiler #112

merged 1 commit into from
Feb 14, 2024

Conversation

pps83
Copy link
Contributor

@pps83 pps83 commented Feb 14, 2024

Replace check for _M_X64 with _M_IX86 to make sure x86 builds can be compiled

@pps83
Copy link
Contributor Author

pps83 commented Feb 14, 2024

after pulling latest I got tons of compilation errors:

1>FastPFor\headers\simdbitpacking.h(14,48): error C2061: syntax error: identifier '__m128i'
1>(compiling source file '../src/coders.cpp')
1>FastPFor\headers\simdbitpacking.h(17,26): error C2061: syntax error: identifier '__m128i'
1>(compiling source file '../src/coders.cpp')
1>FastPFor\headers\simdbitpacking.h(18,31): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
1>(compiling source file '../src/coders.cpp')
1>FastPFor\headers\simdbitpacking.h(18,31): error C2143: syntax error: missing ',' before '*'

...

@pps83 pps83 force-pushed the x86fix branch 2 times, most recently from dbd9959 to 853335c Compare February 14, 2024 10:56
Replace check for `_M_X64` with `_M_IX86` to make sure x86 builds can be compiled
@lemire lemire merged commit 8b02ced into lemire:master Feb 14, 2024
4 checks passed
@pps83 pps83 deleted the x86fix branch February 14, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants