Skip to content

Commit

Permalink
Remove new tags for now
Browse files Browse the repository at this point in the history
This will probably need to be re-added, but the goal is to keep
this PR focused on updating the format of the tags rather than the
content. We probably need to give some more thought to how tags
should be inherited to reduce duplication between estimators as well.
  • Loading branch information
aazuspan committed Dec 4, 2024
1 parent 3af5ece commit 854a4fd
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
7 changes: 0 additions & 7 deletions src/sknnr/_gnn.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,3 @@ class GNNRegressor(YFitMixin, OrdinationKNeighborsRegressor):

def _get_transformer(self) -> TransformerMixin:
return CCATransformer(self.n_components)

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
tags.target_tags.single_output = False
tags.target_tags.two_d_labels = True

return tags
2 changes: 0 additions & 2 deletions src/sknnr/transformers/_cca_transformer.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,5 @@ def fit_transform(self, X, y):
def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
tags.target_tags.required = True
tags.target_tags.single_output = False
tags.target_tags.two_d_labels = True

return tags

0 comments on commit 854a4fd

Please sign in to comment.