Windows compatibility #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose this PR would be incomplete without a screenshot, so here it is:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to compile
tton Windows, I faced the following bugs.pathpassed toreadPackedFilewas formatted aswords\1000eninstead ofwords/1000en. This is problematic since thepackedFilesmap has hard-coded keys in thewords/1000enformat. To fix this bug, I replaced the call tofilepath.Joinwith a hard-coded/.HOMEenvironment variable is not defined on Windows. I was able to define$env:HOME = $env:USERPROFILEand usettsuccessfully, so I updated the program to perform this substitution when theHOMEenvironment variable is not defined.These two changes make
ttat least minimally usable on Windows!