Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Thanks for the work on lemonade!
So I'm interested in adding a logger (#20) to work some other things out
I'm new to writing go code, so please excuse any errors - I also need a little guidance on how to get the logger instance into the rpc methods (since the server may set a different log level, it needs the right logger instance)
(EDIT: Looks like I can fix this with #21)
I also wanted to get your thoughts on how to do the logging - assuming we want log levels, it seems a 3rd party library would be better than the stdlib log package. I've done a some googling, and log15 seems reasonable - https://0value.com/about-Go-logging some comprehensive thoughts.
Cheers, lmk!