Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass CKEditor instance on ready callback #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MicahFulton
Copy link

This solves issue #37

  • Adds the ability to get the reference to the editor instance on ready().
  • Updates the angular model on the selection change and paste events.

…ready(). This also updates the angular model on the selection change and paste events.
@mckoon
Copy link

mckoon commented Jun 27, 2016

The ability to get the CKEditor instance in the provided ready callback seems like a good change. I would like to use this instead of my separate directive to get the instance.

Is this something that is likely to be merged?

Thanks!

iboshkov pushed a commit to iboshkov/angular-ckeditor that referenced this pull request Oct 17, 2016
@JBustin JBustin self-assigned this Nov 2, 2016
@@ -41,7 +41,7 @@
// Initialize the editor content when it is ready.
controller.ready().then(function initialize() {
// Sync view on specific events.
['dataReady', 'change', 'blur', 'saveSnapshot'].forEach(function (event) {
['dataReady', 'change', 'blur', 'saveSnapshot', 'selectionChange', 'paste'].forEach(function (event) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why model should be sync on selectionChange event ?

@JBustin
Copy link

JBustin commented Nov 2, 2016

@mckoon
We prepare a release with many fixes. Could you remove the minification of this PR ?
Thx

@mckoon
Copy link

mckoon commented Nov 2, 2016

@JBustin - I think you mentioned me by mistake; this PR is from @MicahFulton not me.

Thanks

@coolduebtn
Copy link

when will the changes be merged on the master. I am waiting for this fix eagerly.

@JBustin
Copy link

JBustin commented Nov 7, 2016

@MicahFulton
We prepare a release with many fixes. Could you remove the minification of this PR ?
Thx

@coolduebtn
Copy link

@JBustin Can you please merge the changes on master asap. I need this change urgently or else I will have to create a separate directive just with this change..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants