Windows fixes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I choose to do this rather than making both return a result type because it allows both implementation to use From instead of making one use TryFrom.
raphaelcohn
reviewed
Feb 21, 2020
|
@raphaelcohn I made a note in the commit about mirroring the Unix API. I choose to do this rather than making both return a result type because it allows both implementation to use From instead of making one use TryFrom. Is it guaranteed on Unix that they don't return null? I wouldn't have expected that. I'm happy to change it back and make the opposite change on the Unix impl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this! I've got it working on Windows with a few small modifications.
Also, while I can view the hash of the IntelSEAPI fork that this uses, I couldn't check it out. I'm not sure why, exactly. I tried both
git submodule initandgit checkout <hash>and neither were able to see that hash in the tree. I ended up downloading it as a zip and extracting it into the correct place.