Add TCP keepalive option #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
reviewed
Mar 21, 2023
Comment on lines
+128
to
+144
| if status == PendingStatus::Ready { | ||
| if let Some(keepalive) = &self.keepalive { | ||
| #[cfg(target_os = "windows")] | ||
| let socket = unsafe { Socket::from_raw_socket(self.stream.as_raw_socket()) }; | ||
| #[cfg(not(target_os = "windows"))] | ||
| let socket = unsafe { Socket::from_raw_fd(self.stream.as_raw_fd()) }; | ||
|
|
||
| if let Err(e) = socket.set_tcp_keepalive(keepalive) { | ||
| log::warn!("TCP set keepalive error: {}", e); | ||
| } | ||
|
|
||
| // Don't drop so the underlying socket is not closed. | ||
| forget(socket); | ||
| } | ||
| } | ||
|
|
||
| status |
There was a problem hiding this comment.
I'm wondering why do this here instead of in connect()/listen() methods.
Could we get rid of the unsafe code building the socket with socket2, and once it's built, get the stream? instead of building the stream and getting the socket from it?
There was a problem hiding this comment.
We cannot do that in listen() because it concerns the accepted socket, not the listener socket. We could do it in accept() but mio does quite a bit of platform dependent stuff in the UNIX path which contains unsafe as well. We would loose that or have to copy and maintain it ourselves. I'd rather avoid that and live with the unsafe code.
(The Windows path just calls std::net::TcpListener::accept(), though.)
The reason the actual work is done when pending() returns PendingStatus::Ready is that on Windows the option cannot be set during connect (when connect() was called but the socket is not yet connected). Also this way it applies to both outgoing and incoming connections. Signed-off-by: Konrad Gräfe <kgraefe@paktolos.net>
Signed-off-by: Konrad Gräfe <kgraefe@paktolos.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.