[bugfix] Skip warning on type interfaces

Similar to import-js#1377, we don't want this rule to apply to exported interfaces.
lencioni · Jul 19, 2019 · 582236b · 582236b
1 parent b51aa2f
commit 582236b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/src/rules/prefer-default-export.js b/src/rules/prefer-default-export.js
@@ -47,12 +47,16 @@ module.exports = {
         // if there are specifiers, node.declaration should be null
         if (!node.declaration) return
 
-        // don't warn on single type aliases or declarations
+        // don't warn on single type aliases, declarations, or interfaces
         if (node.exportKind === 'type') return
 
+        const { type } = node.declaration
+
         if (
-          node.declaration.type === 'TSTypeAliasDeclaration' ||
-          node.declaration.type === 'TypeAlias'
+          type === 'TSTypeAliasDeclaration' ||
+          type === 'TypeAlias' ||
+          type === 'TSInterfaceDeclaration' ||
+          type === 'InterfaceDeclaration'
         ) {
           return
         }

diff --git a/tests/src/rules/prefer-default-export.js b/tests/src/rules/prefer-default-export.js
@@ -175,6 +175,13 @@ context('Typescript', function() {
           },
           parserConfig,
         ),
+        test (
+          {
+            code: 'export interface foo { bar: string; }',
+            parser,
+          },
+          parserConfig,
+        ),
       ],
       invalid: [],
     });