Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Cancel app creation button #67

Merged
merged 4 commits into from
Jan 2, 2023
Merged

feat: Cancel app creation button #67

merged 4 commits into from
Jan 2, 2023

Conversation

jonas-martinez
Copy link
Collaborator

@jonas-martinez jonas-martinez commented Dec 30, 2022 •
edited
Loading

Closes #64

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I included unit tests that cover my changes
  • I added/updated the documentation about my changes
  • I made my own code-review before requesting one

Description of the changes

Now shows a new button with text "Cancel" or "Logout" when the user does not have an app on his account.

image

@jonas-martinez jonas-martinez added the enhancement New feature or request label Dec 30, 2022
@jonas-martinez jonas-martinez self-assigned this Dec 30, 2022
taorepoara
taorepoara requested changes Jan 2, 2023
View reviewed changes
lib/views/create_project_form.dart Outdated Show resolved Hide resolved
lib/views/create_project_form.dart Outdated Show resolved Hide resolved
lib/views/create_project_form.dart Outdated Show resolved Hide resolved
@jonas-martinez
Copy link
Collaborator Author

@taorepoara I edited the PR following your review. I changed the image in the description to be up to date with the changes. What do you think of these changes?

taorepoara
taorepoara requested changes Jan 2, 2023
View reviewed changes
lib/views/create_project_form.dart Outdated Show resolved Hide resolved
lib/views/create_project_form.dart Outdated Show resolved Hide resolved
lib/views/create_project_form.dart Show resolved Hide resolved
@taorepoara taorepoara merged commit 1b6a5f6 into beta Jan 2, 2023
@taorepoara taorepoara deleted the cancel-app-creation branch January 2, 2023 17:13
@shiipou
Copy link
Contributor

shiipou commented Jan 2, 2023

🎉 This PR is included in version 1.0.0-beta.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shiipou
Copy link
Contributor

shiipou commented Aug 11, 2023

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shiipou
Copy link
Contributor

shiipou commented Aug 21, 2023

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shiipou
Copy link
Contributor

shiipou commented Oct 8, 2023

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taorepoara taorepoara taorepoara approved these changes

Assignees

@jonas-martinez jonas-martinez

Labels
enhancement New feature or request released on @alpha released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Possibility to cancel app creation
3 participants
@jonas-martinez @shiipou @taorepoara