Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OAuth disconnect #93

Merged
merged 8 commits into from
Feb 15, 2024
Merged

fix: OAuth disconnect #93

merged 8 commits into from
Feb 15, 2024

Conversation

jonas-martinez
Copy link
Collaborator

@jonas-martinez jonas-martinez commented Aug 31, 2023

Description of the changes

If there is no access token in local storage, the access token in OAuthModel should not act as an authentication method.

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

Technical highlight/advice

@jonas-martinez jonas-martinez added the bug Something isn't working label Aug 31, 2023
@jonas-martinez jonas-martinez self-assigned this Aug 31, 2023
@taorepoara
Copy link
Member

I've made a PR to really disconnect the user that should be added to this PR: lenra-io/client_common#96

@jonas-martinez
Copy link
Collaborator Author

See ory/hydra#1754 (comment) for a potential fix

@jonas-martinez jonas-martinez added the help wanted Extra attention is needed label Oct 4, 2023
@taorepoara
Copy link
Member

Waiting for lenra-io/client_common#105

@jonas-martinez
Copy link
Collaborator Author

I tested this on the main page (store page) of the client but I did NOT test it on an application.
We might need to add some documentation to help test applications locally because it became really tiring to setup an app.
If we could maybe add a mix task to automatically create an app in the database with the proper data and already deployed. We could use an already working deployment from git for that.

Copy link
Member

@taorepoara taorepoara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK

@taorepoara taorepoara merged commit d60695f into beta Feb 15, 2024
3 checks passed
@taorepoara taorepoara deleted the fix-oauth-disconnect branch February 15, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants