fix: UserResponse can now be null #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-martinez
added
bug
|
@jonas-martinez Can you explain this PR please ? |
|
@taorepoara I added some context in the PR description |
|
In my opinion this can't happen or it should return an error from the server. |
|
@taorepoara I'm going to see if I can do something, I'm moving this PR to |
|
This PR can be closed as an alternative has been found involving the server sending an error instead of nil. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
Linked to lenra-io/server#399
There was a problem when the access token was invalid where the server tried to get the user linked to this access token from the DB but because the access token is invalid, it returned
nilinstead of the user object.Checklist
I included unit tests that cover my changes
I added/updated the documentation about my changes