Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove AuthModel to only use OAuthModel #103

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

jonas-martinez
Copy link
Collaborator

@jonas-martinez jonas-martinez commented Oct 17, 2023

About this PR

Linked to lenra-io/server#399

Following the issue referenced above, I have done a rework on the authentication process on client-common. This rework involves removing the AuthModel which was an old class used for handling authentication. I regrouped everything in the OAuthModel which is the new Model for handling authentication on Lenra. This also simplifies the authentication checks on the backoffice as you can see on the following pull request : lenra-io/backoffice#123.

How to test these changes

You can test these changes by using the backoffice's PR referenced above and using this branch as the client-common dependency in the backoffice. Then, run the latest server version and make sure that you have created an oauth client using the oauth documentation in the docs folder of the server.

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@jonas-martinez jonas-martinez added the enhancement New feature or request label Oct 17, 2023
@jonas-martinez jonas-martinez self-assigned this Oct 17, 2023
@taorepoara taorepoara merged commit c3f4271 into main Oct 17, 2023
15 checks passed
@taorepoara taorepoara deleted the remove-auth-model branch October 17, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants