fix: allow to set environment in Config.instance #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shiipou <shiishii@nocturlab.fr>
jonas-martinez
requested changes
Sep 26, 2023
Co-authored-by: Jonas Martinez <36544012+jonas-martinez@users.noreply.github.com>
…does-not-have-an-environment
taorepoara
approved these changes
Sep 29, 2023
taorepoara
deleted the
kubernetes-130-bug-sentry-client-backoffice-does-not-have-an-environment
branch
taorepoara
pushed a commit
that referenced
this pull request
Sep 29, 2023
* fix: allow to set environment in Config.instance Signed-off-by: shiipou <shiishii@nocturlab.fr> * Update lib/config/config.dart Co-authored-by: Jonas Martinez <36544012+jonas-martinez@users.noreply.github.com> --------- Signed-off-by: shiipou <shiishii@nocturlab.fr> Co-authored-by: Jonas Martinez <36544012+jonas-martinez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
Closes https://github.com/lenra-io/kubernetes/issues/130
We can't set environment at runtime for client and backoffice.
This PR allow to set in the index.html file the metadata environment with a value at runtime instead of being stuck at compile time.
How to test my changes
Checklist
I included unit tests that cover my changes
I added/updated the documentation about my changes