Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Manage template file when path is defined #404

Merged
merged 1 commit into from
May 15, 2024

Conversation

taorepoara
Copy link
Member

@taorepoara taorepoara commented May 15, 2024

About this PR

Closes #263

Technical highlight/advice

The upgrade command fails a lot. I've opened an issue for that: #403

How to test my changes

In a Lenra project that have a template file (.template):

  • Move your lenra.yml file in the parent directory and define the relative path to your app directory.
  • Then run the upgrade command
echo "path: ${PWD##*/}" >> lenra.yml
mv lenra.yml ../
cd ../
lenra upgrade

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@taorepoara taorepoara self-assigned this May 15, 2024
@taorepoara taorepoara marked this pull request as ready for review May 15, 2024 14:07
@taorepoara taorepoara merged commit 3e9376e into beta May 15, 2024
11 checks passed
@taorepoara taorepoara deleted the 263-bug-lenra-upgrade-command-does-not-fail branch May 15, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant