Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Material update #123

Merged
merged 3 commits into from
Apr 4, 2024
Merged

fix: Material update #123

merged 3 commits into from
Apr 4, 2024

Conversation

jonas-martinez
Copy link
Contributor

@jonas-martinez jonas-martinez commented Apr 2, 2024

About this PR

This PR is about the Flutter Material update from 2 to 3. It changed some widgets style so we need to change that so that they correspond to the design on Figma.
In this PR I mainly fixed the button which had a too much rounded border following the update of Material. I also found that the Switch widget changed a lot but it is closer to our design so this is good for us. We might need to adapt the thumb size to match our design. I opened another issue for the Switch.

Technical highlight/advice

How to test my changes

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@jonas-martinez jonas-martinez added the bug Something isn't working label Apr 2, 2024
@jonas-martinez jonas-martinez self-assigned this Apr 2, 2024
@jonas-martinez
Copy link
Contributor Author

I still need to find out why the LenraTable component size has changed since Material was updated. It is 6 pixels too big in height.

@jonas-martinez
Copy link
Contributor Author

jonas-martinez commented Apr 3, 2024

The Switch widget also changed in Material 3.
It seems hard to adapt it so we might need to create a custom widget.
https://blog.logrocket.com/advanced-guide-flutter-switches-toggles/#creating-a-custom-animated-switch-button

This image is the expected Switch widget from Lenra's Figma design.

image

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.52%. Comparing base (26cc6d8) to head (3758e55).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             beta     #123      +/-   ##
==========================================
- Coverage   71.71%   71.52%   -0.19%     
==========================================
  Files          38       38              
  Lines         912      906       -6     
==========================================
- Hits          654      648       -6     
  Misses        258      258              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-martinez jonas-martinez merged commit d35639b into beta Apr 4, 2024
12 checks passed
@jonas-martinez jonas-martinez deleted the fix-material branch April 4, 2024 12:22
@shiipou
Copy link
Contributor

shiipou commented Apr 4, 2024

🎉 This PR is included in version 1.0.0-beta.53 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released on @beta
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants