Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update READMe & add License #271

Merged
merged 5 commits into from
Aug 17, 2022
Merged

feat: Update READMe & add License #271

merged 5 commits into from
Aug 17, 2022

Conversation

pichoemr
Copy link
Contributor

#__

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I included unit tests that cover my changes
  • I added/updated the documentation about my changes
  • I made my own code-review before requesting one

Description of the changes

Update README and add license

Technical highlight/advice

@pichoemr pichoemr self-assigned this Jul 29, 2022
@pichoemr pichoemr requested review from jonas-martinez and taorepoara and removed request for jonas-martinez July 29, 2022 10:12
jonas-martinez
jonas-martinez requested changes Jul 29, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jonas-martinez
jonas-martinez reviewed Aug 1, 2022
View reviewed changes
Copy link
Collaborator

@jonas-martinez jonas-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !
Waiting for @taorepoara to review this.

jonas-martinez
jonas-martinez requested changes Aug 1, 2022
View reviewed changes
Copy link
Collaborator

@jonas-martinez jonas-martinez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a part of the doc in the last example that is not translated to english, can you change this @pichoemr ?

jonas-martinez
jonas-martinez requested changes Aug 1, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jonas-martinez
jonas-martinez approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@jonas-martinez jonas-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonas-martinez jonas-martinez merged commit 5cc2a84 into beta Aug 17, 2022
@jonas-martinez jonas-martinez deleted the readme-update branch August 17, 2022 08:33
@shiipou
Copy link
Contributor

shiipou commented Aug 17, 2022

🎉 This PR is included in version 1.0.0-beta.83 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shiipou
Copy link
Contributor

shiipou commented Apr 4, 2023

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@taorepoara
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-martinez jonas-martinez jonas-martinez approved these changes

@taorepoara taorepoara Awaiting requested review from taorepoara

Assignees

@pichoemr pichoemr

Labels
released on @alpha released on @beta released
Projects
Lenra
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pichoemr @shiipou @taorepoara @jonas-martinez