feat: make session cookie #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pichoemr Can you add a description to this PR or link it to an issue to better understand why we add a session cookie ? |
jonas-martinez
requested changes
Feb 24, 2023
There was a problem hiding this comment.
This is not working properly.
When the keep me logged in box is NOT checked, it works. Here are the logs :
[info] Sent 200 in 21ms
[info] POST /auth/logout
[debug] Processing with LenraWeb.UserController.logout/2
Parameters: %{}
Pipelines: [:api, :ensure_auth_refresh]
[debug] QUERY OK source="guardian_tokens" db=4.8ms idle=1152.8ms
SELECT g0."jti", g0."typ", g0."aud", g0."iss", g0."sub", g0."exp", g0."jwt", g0."claims", g0."inserted_at", g0."updated_at" FROM "guardian_tokens" AS g0 WHERE ((g0."jti" = $1) AND (g0."aud" = $2)) ["48d0b11b-c886-4782-a94f-f06e124f4f15", "lenra"]
[debug] QUERY OK source="users" db=1.6ms idle=982.6ms
SELECT u0."id", u0."first_name", u0."last_name", u0."email", u0."role", u0."inserted_at", u0."updated_at" FROM "users" AS u0 WHERE (u0."id" = $1) [1]
[debug] QUERY OK source="guardian_tokens" db=1.9ms idle=979.7ms
SELECT g0."jti", g0."typ", g0."aud", g0."iss", g0."sub", g0."exp", g0."jwt", g0."claims", g0."inserted_at", g0."updated_at" FROM "guardian_tokens" AS g0 WHERE ((g0."jti" = $1) AND (g0."aud" = $2)) ["48d0b11b-c886-4782-a94f-f06e124f4f15", "lenra"]
[debug] QUERY OK db=7.8ms queue=3.2ms idle=978.1ms
DELETE FROM "guardian_tokens" WHERE "jti" = $1 ["48d0b11b-c886-4782-a94f-f06e124f4f15"]When the keep me logged in box is checked, it does not work. Here are the logs
[info] Sent 200 in 20ms
[info] POST /auth/logout
[debug] Processing with LenraWeb.UserController.logout/2
Parameters: %{}
Pipelines: [:api, :ensure_auth_refresh]
[debug] QUERY OK source="guardian_tokens" db=42.7ms idle=993.3ms
SELECT g0."jti", g0."typ", g0."aud", g0."iss", g0."sub", g0."exp", g0."jwt", g0."claims", g0."inserted_at", g0."updated_at" FROM "guardian_tokens" AS g0 WHERE ((g0."jti" = $1) AND (g0."aud" = $2)) ["48d0b11b-c886-4782-a94f-f06e124f4f15", "lenra"]
[info] Sent 401 in 48ms
[debug] Phoenix.Router halted in :ensure_auth_refresh/2
jonas-martinez
approved these changes
Feb 24, 2023
|
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #313
Checklist
Description of the changes
Technical highlight/advice