Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove template_url env var #404

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

shiipou
Copy link
Contributor

@shiipou shiipou commented Aug 14, 2023

Closes #398

Description of the changes

This remove usage of variable TEMPLATE_URL in server config because it made the server crash at startup.

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

Technical highlight/advice

Signed-off-by: shiipou <shiishii@nocturlab.fr>
@shiipou shiipou added the bug Something isn't working label Aug 14, 2023
@shiipou shiipou self-assigned this Aug 14, 2023
@shiipou shiipou linked an issue Aug 14, 2023 that may be closed by this pull request
@taorepoara taorepoara merged commit ee0aaa8 into beta Aug 18, 2023
24 checks passed
@taorepoara taorepoara deleted the 398-bug-remove-template_url branch August 18, 2023 12:56
@shiipou
Copy link
Contributor Author

shiipou commented Aug 18, 2023

🎉 This PR is included in version 1.0.0-beta.156 🎉

The release is available on:

Your semantic-release bot 📦🚀

@taorepoara
Copy link
Member

🎉 This PR is included in version 1.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@taorepoara
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Remove TEMPLATE_URL
2 participants