Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create a scale to zero config to disable it when not needed #448

Merged

Conversation

taorepoara
Copy link
Member

@taorepoara taorepoara commented Sep 8, 2023

Closes #424

Description of the changes

Since I added the OpenFaaS scale to zero and scale to one, the devtool is broken since it try to call OpenFaaS that does not exist in the devtool...

This PR add a new config

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@taorepoara taorepoara self-assigned this Sep 8, 2023
@taorepoara taorepoara linked an issue Sep 8, 2023 that may be closed by this pull request
@taorepoara taorepoara marked this pull request as ready for review September 9, 2023 07:55
@taorepoara taorepoara merged commit 365069c into beta Sep 9, 2023
6 checks passed
@taorepoara taorepoara deleted the 424-bug-start-and-stop-openfaas-app-broke-the-devtool branch September 9, 2023 13:39
@taorepoara
Copy link
Member Author

🎉 This PR is included in version 1.0.0-beta.158 🎉

The release is available on:

Your semantic-release bot 📦🚀

@taorepoara
Copy link
Member Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Start and stop OpenFaaS app broke the devtool
1 participant