Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Use the new API project with breaking changes #452

Merged
merged 17 commits into from
Sep 19, 2023
Merged

feat!: Use the new API project with breaking changes #452

merged 17 commits into from
Sep 19, 2023

Conversation

taorepoara
Copy link
Member

@taorepoara taorepoara commented Sep 13, 2023 •
edited
Loading

About this PR

Adapt to API breaking changes:

type => _type
action => listener
remove deprecated elements

Wating for lenra-io/ex_component_schema#13 to be merged

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@taorepoara taorepoara self-assigned this Sep 13, 2023
@taorepoara taorepoara mentioned this pull request Sep 14, 2023
Closed
12 tasks
@taorepoara taorepoara changed the title feat: Replace action keyword by listener feat!: Use the new API project with breaking changes Sep 15, 2023
@taorepoara taorepoara added the enhancement New feature or request label Sep 15, 2023
@taorepoara taorepoara marked this pull request as ready for review September 15, 2023 15:17
@taorepoara taorepoara mentioned this pull request Sep 15, 2023
Merged
11 tasks
pichoemr
pichoemr suggested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@pichoemr pichoemr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some format error

apps/lenra/lib/lenra/services/openfaas_services.ex Outdated Show resolved Hide resolved
libs/application_runner/lib/channels/routes_channel.ex Show resolved Hide resolved
libs/application_runner/lib/environment/manifest_handler.ex Show resolved Hide resolved
libs/application_runner/lib/router.ex Show resolved Hide resolved
@taorepoara @pichoemr
Apply suggestions from code review
6750250 
Co-authored-by: Emric Pichonnier <emric.pichonnier@lenra.io>
pichoemr
pichoemr previously approved these changes Sep 19, 2023
View reviewed changes
@taorepoara taorepoara merged commit 6950f85 into beta Sep 19, 2023
6 checks passed
@taorepoara taorepoara deleted the replace-action-by-listener branch September 19, 2023 09:02
@taorepoara
Copy link
Member Author

🎉 This PR is included in version 1.0.0-beta.162 🎉

The release is available on:

Your semantic-release bot 📦🚀

@taorepoara
Copy link
Member Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichoemr pichoemr pichoemr approved these changes

@Nesqwik Nesqwik Awaiting requested review from Nesqwik

Assignees

@taorepoara taorepoara

Labels
enhancement New feature or request released on @beta released
Projects
Lenra
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taorepoara @pichoemr