Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: No default routes #454

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: No default routes #454

merged 1 commit into from
Sep 19, 2023

Conversation

taorepoara
Copy link
Member

@taorepoara taorepoara commented Sep 19, 2023

About this PR

The default routes made the app try to call the main route that might not exists

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@taorepoara taorepoara marked this pull request as ready for review September 19, 2023 11:29
@taorepoara taorepoara merged commit 37cd738 into beta Sep 19, 2023
30 of 34 checks passed
@taorepoara taorepoara deleted the fix-default-routes branch September 19, 2023 11:49
@taorepoara
Copy link
Member Author

🎉 This PR is included in version 1.0.0-beta.163 🎉

The release is available on:

Your semantic-release bot 📦🚀

@taorepoara
Copy link
Member Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant