fix: Hydra OAuth Token invalid when server is reset #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taorepoara
approved these changes
Apr 12, 2024
|
I'll look at the devtool to see if the problem is linked even if the workflow is not the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
Very closely linked to lenra-io/devtool#210
Technical highlight/advice
Do not return errors when the oauth token is invalid, just redirect to the register page as we don't know what could have caused the issue. It is better to get a new token than trying to fix an unfixable data corruption.
How to test my changes
Please see @taorepoara comments on lenra-io/devtool#210 for testing instructions. You basically need to start a server, register and connect. Then you need to reset the server and try to log in back into it with the same old oauth token. It should redirect you to the register page.
Before my change it just showed an error.
Checklist
I included unit tests that cover my changes
I added/updated the documentation about my changes