Cleanup onNetworkOffline/Online impls within ClusterManager

Signed-off-by: Sebastian Malton <sebastian@malton.name>
lensapp · Jan 17, 2023 · 1b2d306 · 1b2d306
1 parent e066ab0
commit 1b2d306
Showing 1 changed file with 25 additions and 31 deletions.
diff --git a/src/main/cluster/manager.ts b/src/main/cluster/manager.ts
@@ -235,41 +235,35 @@ export class ClusterManager {
     }
   }
 
-  protected onNetworkOffline = () => {
+  protected onNetworkOffline = async () => {
     this.dependencies.logger.info(`${logPrefix} network is offline`);
-    this.dependencies.store.clustersList.forEach((cluster) => {
-      if (!cluster.disconnected) {
-        cluster.online = false;
-        cluster.accessible = false;
-
-        void (async () => {
-          try {
-            await this.dependencies
-              .getClusterConnection(cluster)
-              .refreshConnectionStatus();
-          } catch {
-            // ignore
-          }
-        })();
-      }
-    });
+
+    await Promise.allSettled(
+      this.dependencies.store.clustersList
+        .filter(cluster => !cluster.disconnected)
+        .map(async (cluster) => {
+          cluster.online = false;
+          cluster.accessible = false;
+
+          await this.dependencies
+            .getClusterConnection(cluster)
+            .refreshConnectionStatus();
+        }),
+    );
   };
 
-  protected onNetworkOnline = () => {
+  protected onNetworkOnline = async () => {
     this.dependencies.logger.info(`${logPrefix} network is online`);
-    this.dependencies.store.clustersList.forEach((cluster) => {
-      if (!cluster.disconnected) {
-        void (async () => {
-          try {
-            await this.dependencies
-              .getClusterConnection(cluster)
-              .refreshConnectionStatus();
-          } catch {
-            // ignore
-          }
-        })();
-      }
-    });
+
+    await Promise.allSettled(
+      this.dependencies.store.clustersList
+        .filter(cluster => !cluster.disconnected)
+        .map((cluster) => (
+          this.dependencies
+            .getClusterConnection(cluster)
+            .refreshConnectionStatus()
+        )),
+    );
   };
 
   stop() {