Skip to content

Commit

Permalink
Improve naming
Browse files Browse the repository at this point in the history
Signed-off-by: Sebastian Malton <sebastian@malton.name>
  • Loading branch information
Nokel81 committed Nov 28, 2022
1 parent bef83d1 commit 78397d7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import catalogEntitySettingItemsInjectable from "./settings.injectable";
export type HasCatalogEntitySettingItems = (entity: CatalogEntity) => boolean;

const hasCatalogEntitySettingItemsInjectable = getInjectable({
id: "has-catalog-entity-settings",
id: "has-catalog-entity-setting-items",
instantiate: (di): HasCatalogEntitySettingItems => (entity) => {
const items = di.inject(catalogEntitySettingItemsInjectable, entity);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ interface Dependencies {
getClusterById: GetClusterById;
}

function NonInjectedProxyKubernetesClusterSettings({ entity, getClusterById }: EntitySettingViewProps & Dependencies) {
function NonInjectedNamespaceKubernetesClusterSettings({ entity, getClusterById }: EntitySettingViewProps & Dependencies) {
const cluster = getClusterById(entity.getId());

if (!cluster) {
Expand All @@ -29,7 +29,7 @@ function NonInjectedProxyKubernetesClusterSettings({ entity, getClusterById }: E
);
}

const NamespaceKubernetesClusterSettings = withInjectables<Dependencies, EntitySettingViewProps>(NonInjectedProxyKubernetesClusterSettings, {
const NamespaceKubernetesClusterSettings = withInjectables<Dependencies, EntitySettingViewProps>(NonInjectedNamespaceKubernetesClusterSettings, {
getProps: (di, props) => ({
...props,
getClusterById: di.inject(getClusterByIdInjectable),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import type { CatalogEntity } from "../../api/catalog-entity";
import { entitySettingInjectionToken } from "./token";

const catalogEntitySettingItemsInjectable = getInjectable({
id: "entity-settings",
id: "catalog-entity-setting-items",
instantiate: (di, entity) => {
const computedInjectMany = di.inject(computedInjectManyInjectable);
const items = computedInjectMany(entitySettingInjectionToken);
Expand Down

0 comments on commit 78397d7

Please sign in to comment.