Add catalogAddMenu filter to CatalogCategory #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panuhorsmalahti
requested review from
jakolehm,
chenhunghan,
Nokel81 and
msa0311
panuhorsmalahti
force-pushed
the
feature/add-catalog-menu-filter
branch
from
ac128f6 to
bcd777d
Compare
panuhorsmalahti
changed the title
chenhunghan
reviewed
Sep 2, 2021
panuhorsmalahti
force-pushed
the
feature/add-catalog-menu-filter
branch
from
74643fe to
494cbbf
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
panuhorsmalahti
force-pushed
the
feature/add-catalog-menu-filter
branch
from
494cbbf to
a461ac5
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Nokel81
reviewed
Sep 13, 2021
| public addMenuFilter(fn: AddMenuFilter): Disposer { | ||
| this.filters.add(fn); | ||
|
|
||
| return once(() => void this.filters.delete(fn)); |
There was a problem hiding this comment.
Only nit would be that if the category is removed, these should be removed too.
There was a problem hiding this comment.
Why? Do you mean if I call the Disposer returned by CatalogCategoryRegistry::add, I should remove the filters from the CatalogCategory instance? Doesn't sound right to me
Nokel81
approved these changes
Sep 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catalogAddMenucontext menu items. Extension can e.g. filter certain menu items from the context menu.The filter can be removed with the returned disposer:
CatalogCategoryclasses.