Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix development on M1 (Apple Silicon) #3759

Merged
merged 3 commits into from
Sep 9, 2021
Merged

Fix development on M1 (Apple Silicon) #3759

merged 3 commits into from
Sep 9, 2021

Conversation

jakolehm
Copy link
Contributor

@jakolehm jakolehm commented Sep 9, 2021 •
edited
Loading

  • node-sass does not work on arm64 and is already deprecated -> switched to sass
  • removed @types/electron-window-state because it's not needed and it pulls old electron as a dependency
  • switched ts-node to transpile only (something strange with ts-node on arm64)

sass emits lots of deprecation warnings from our codebase which need to be fixed in a separate PR.

@jakolehm
m1 compatible package.json
7de7fdb 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm
fix ts-node tsconfig
0b408f3 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm
switch from node-sass to sass
9733f4b 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm added enhancement New feature or request area/macos labels Sep 9, 2021
@jakolehm jakolehm added this to the 5.3.0 milestone Sep 9, 2021
@jakolehm jakolehm requested a review from a team as a code owner September 9, 2021 06:03
@jakolehm jakolehm merged commit 2f94de5 into master Sep 9, 2021
@jakolehm jakolehm deleted the dev-on-m1 branch September 9, 2021 06:31
@jakolehm jakolehm mentioned this pull request Sep 9, 2021
Closed
@jim-docker jim-docker mentioned this pull request Oct 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevalla nevalla nevalla approved these changes

@aleksfront aleksfront aleksfront approved these changes

Assignees
No one assigned
Labels
area/macos enhancement New feature or request
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jakolehm @nevalla @aleksfront