Add more file system metrics to the pod and container graphs #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcbachmann
force-pushed
the
filesystem-metrics
branch
2 times, most recently
from
fb6aed7
to
edeb237
Compare
Nokel81
added
area/metrics
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Marc Bachmann <marc.brookman@gmail.com>
marcbachmann
force-pushed
the
filesystem-metrics
branch
from
edeb237
to
5a1472f
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
marcbachmann
requested review from
Nokel81 and
jim-docker
and removed request for
a team
Nokel81
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What would you like to be added:
At the moment lens doesn't support
container_fs_usage_bytesmetrics on a pod/container level as that's not supported in cAdvisor yet (gets actively worked on).Other metrics we could add are
container_fs_writes_bytes_totalandcontainer_fs_reads_bytes_total. Those are already supported and working in most systems.Additionally it would also be neat to have the PVC I/O metrics directly in the graph, but that will need more visualization work.
Why is this needed:
While lens is no monitoring solution, people in operations could still benefit from the additional stats.
Would that be easy to support and something you want in here?