Add URL display to weblink URLs #4046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
requested review from
nevalla,
jakolehm and
panuhorsmalahti
and removed request for
a team
aleksfront
approved these changes
Oct 18, 2021
Comment on lines
+49
to
+62
| { | ||
| apiVersions: [WebLink.apiVersion], | ||
| kind: WebLink.kind, | ||
| components: { | ||
| Details: ({ entity }: CatalogEntityDetailsProps<WebLink>) => ( | ||
| <> | ||
| <DrawerTitle title="More Information" /> | ||
| <DrawerItem name="URL"> | ||
| {entity.spec.url} | ||
| </DrawerItem> | ||
| </> | ||
| ), | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Ideally, this file shouldn't contain additional information for different kind of entities. Such details must be added through the specific entity files.
There was a problem hiding this comment.
I don't understand, how is this different than, say, the file src/renderer/initializers/kube-object-details-registry.tsx?
| components: { | ||
| Details: ({ entity }: CatalogEntityDetailsProps<WebLink>) => ( | ||
| <> | ||
| <DrawerTitle title="More Information" /> |
There was a problem hiding this comment.
I don't like one word titles like that, though I also don't like the title I have now...
I would have wanted it to be in the same format as the lines above but couldn't get it to be. Probably a place for improvement in the future.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton sebastian@malton.name
fixes #3840