Stop using @electron/remote to obtain app.getPath() #4078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokel81
requested review from
jweak and
jim-docker
and removed request for
a team
Nokel81
force-pushed
the
remove-getPath
branch
from
915f4ad to
c5daf5c
Compare
Nokel81
changed the title
Nokel81
changed the title
jweak
reviewed
Oct 26, 2021
jweak
reviewed
Oct 26, 2021
jim-docker
reviewed
Oct 26, 2021
| } | ||
| } | ||
|
|
||
| private static initMain(): void { |
There was a problem hiding this comment.
This gets called for sure before initRenderer()?
There was a problem hiding this comment.
I hope so, it gets called in the main process whereas initRenderer gets called in each frame.
jim-docker
reviewed
Oct 27, 2021
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
- Initialize entire map in bootstrap() - Updated unit tests Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
force-pushed
the
remove-getPath
branch
from
215fca7 to
9a17097
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Signed-off-by: Sebastian Malton <sebastian@malton.name>
|
@jim-docker PTALA |
Signed-off-by: Sebastian Malton <sebastian@malton.name>
jim-docker
approved these changes
Oct 27, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton sebastian@malton.name
Fixes a bug where, for some reason,
remote.appthrows an error (during early lifetime of a frame). This fixes the issue by instead initializing the whole set inbootstrap()which is called far enough along that it shouldn't observe that behaviour.The changes to
createStorageare required because they were the initial error case, they now wait for bootstrap to callAppPaths.init()and then they will initialize themselves.