Cleanup dependentStores #4089
Merged
Cleanup dependentStores #4089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
nevalla
requested review from
Nokel81 and
aleksfront
and removed request for
a team
Nokel81
requested changes
Oct 20, 2021
| @@ -79,7 +76,7 @@ export class Deployments extends React.Component<Props> { | |||
| isConfigurable | |||
| tableId="workload_deployments" | |||
| className="Deployments" store={deploymentStore} | |||
| dependentStores={[replicaSetStore, podsStore, nodesStore, eventStore]} | |||
There was a problem hiding this comment.
So looking at it, we actually do use podsStore and replicaSetStore in DeploymentDetails (though that component calls reloadAll() for some reason. I think it would be better to remove that reload calls instead.
There was a problem hiding this comment.
User can navigate to Deployment details elsewhere too.
Nokel81
approved these changes
Oct 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary dependent stores from workload list components.