Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix captitalization in CrdResources component #4093

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Fix captitalization in CrdResources component #4093

merged 2 commits into from
Oct 20, 2021

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Oct 20, 2021

  • Title should just be .spec.names.kind like the sidebar

  • Searching should just be .spec.names.plural

Signed-off-by: Sebastian Malton sebastian@malton.name

fixes #4081

@Nokel81
Fix captitalization in CrdResources component
4440af9 
- Title should just be .spec.names.kind like the sidebar

- Searching should just be .spec.names.plural

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 added bug Something isn't working area/ui labels Oct 20, 2021
@Nokel81 Nokel81 requested a review from a team as a code owner October 20, 2021 15:33
@Nokel81 Nokel81 requested review from jweak and aleksfront and removed request for a team October 20, 2021 15:33
@jim-docker
Copy link
Contributor

Not quite?

Screen Shot 2021-10-20 at 12 03 12 PM

The title is not plural, and the search placeholder is the same?

@Nokel81
Copy link
Collaborator Author

Nokel81 commented Oct 20, 2021

The title is the same as sidebar (which is not plural either). I think that it would be better to use the plural form of the name for search.

@jim-docker
Copy link
Contributor

Not quite?

The title is not plural, and the search placeholder is the same?

Or that is what you intended?

@jim-docker
Copy link
Contributor

The title is the same as sidebar (which is not plural either). I think that it would be better to use the plural form of the name for search.

So title is now singular, and search bar is still plural but all lowercase?

@Nokel81
Copy link
Collaborator Author

Nokel81 commented Oct 20, 2021

Yes that is the change, I can make the search singlular too if you think that would be better. It would be very cool (IMO) if we did the following transform "ClusterIssuer" -> "Cluster Issuers" but that is probably a bit too tricky

@jim-docker
Copy link
Contributor

Can you make the placeholder "ClusterIssuer search..." ?

@Nokel81
Copy link
Collaborator Author

Nokel81 commented Oct 20, 2021

Sure

@Nokel81
Switch search placeholder
df5df3e 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 requested a review from jim-docker October 20, 2021 16:30
@Nokel81 Nokel81 merged commit f52a229 into master Oct 20, 2021
@Nokel81 Nokel81 deleted the issue-4081 branch October 20, 2021 19:42
@jim-docker jim-docker mentioned this pull request Oct 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-docker jim-docker jim-docker approved these changes

@jweak jweak Awaiting requested review from jweak jweak is a code owner automatically assigned from lensapp/lens-ide

@aleksfront aleksfront Awaiting requested review from aleksfront aleksfront is a code owner automatically assigned from lensapp/lens-ide

Assignees
No one assigned
Labels
area/ui bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent casing of CRDs
2 participants
@Nokel81 @jim-docker