Allow port-forwards to be restarted with the same local port #4097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
jim-docker
requested review from
Nokel81 and
aleksfront
and removed request for
a team
|
Does this completely resolve the mentioned issue? |
Nokel81
reviewed
Oct 21, 2021
| @@ -170,7 +166,7 @@ export class PortForwardDialog extends Component<Props> { | |||
| contentClass="flex gaps column" | |||
| next={this.startPortForward} | |||
| nextLabel={this.currentPort === 0 ? "Start" : "Restart"} | |||
| disabledNext={!this.ready} | |||
| disabledNext={false} | |||
There was a problem hiding this comment.
nit: could just be removed
Nokel81
previously approved these changes
Oct 21, 2021
no, just wanted to make sure this PR is linked to that issue |
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
Nokel81
approved these changes
Oct 21, 2021
Nokel81
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current design restricts the user from restarting a port-forward with the same port. The restriction is not technically necessary, and in the event that the associated pod is terminated/restarted lifting this restriction makes it easy for the user to reconnect the port-forward. (the
kubectl port-forwardprocess does not stop when the associated pod is terminated).Signed-off-by: Jim Ehrismann jehrismann@mirantis.com
addresses #2340