Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix immer/merge bug #4107

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Fix immer/merge bug #4107

merged 2 commits into from
Oct 22, 2021

Conversation

jim-docker
Copy link
Contributor

This eliminates the error messages mentioned here.

But selected namespaces are always reset to just "default", and saved port-forwards are lost after disconnecting and then reconnecting the cluster.

It's a problem on loading the lens-local-storage files, because the contents are correct after disconnecting the cluster. Somewhere in the process of connecting the cluster the data is overwritten. This did work before PR #3882

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
@jim-docker jim-docker requested review from ixrock and Nokel81 October 21, 2021 16:45
Signed-off-by: Roman <ixrock@gmail.com>
@jakolehm jakolehm added the bug Something isn't working label Oct 22, 2021
@ixrock ixrock marked this pull request as ready for review October 22, 2021 10:51
@ixrock ixrock requested a review from a team as a code owner October 22, 2021 10:51
@Nokel81 Nokel81 linked an issue Oct 22, 2021 that may be closed by this pull request
Copy link
Collaborator

@Nokel81 Nokel81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nokel81 Nokel81 merged commit 169f443 into master Oct 22, 2021
@Nokel81 Nokel81 deleted the fix/immer-update branch October 22, 2021 13:23
@Nokel81 Nokel81 changed the title attempt to fix immer/merge bug Fix immer/merge bug Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot assign to read only property '0' of object
4 participants