Revert "Upgrade to Electron@v13.6.0 (#4145)" #4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 566d2a6. Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
This reverts commit b4d5e74. Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
jakolehm
approved these changes
Oct 29, 2021
chenhunghan
approved these changes
Oct 29, 2021
|
Proper fix (WIP) #4185 |
Merged
chenhunghan
added a commit
that referenced
this pull request
Nov 1, 2021
Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>
chenhunghan
added a commit
that referenced
this pull request
Nov 2, 2021
Signed-off-by: Hung-Han (Henry) Chen <chenhungh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commits 566d2a6 and b4d5e74.
The new electron version changed how certificate chain is validated and is causing a technical issue related to mac-ca/win-ca. Lets revert the update now, and update electron after a proper fix for the certificate issue.
Signed-off-by: Panu Horsmalahti phorsmalahti@mirantis.com