'About Port Forwarding' notification #4270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
jim-docker
requested review from
nevalla and
jakolehm
and removed request for
a team
Nokel81
previously approved these changes
Nov 5, 2021
Comment on lines
95
to
96
| // determine how many port-forwards are already active | ||
| const { length } = await getPortForwards(); |
There was a problem hiding this comment.
shouldn't this be within the try?
chenhunghan
reviewed
Nov 5, 2021
| import { getHostedClusterId } from "../utils"; | ||
|
|
||
|
|
||
| export async function aboutPortForwarding() { |
There was a problem hiding this comment.
Does this need to be async?
There was a problem hiding this comment.
I wondered that myself. Probably not, thanks
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
Nokel81
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guide the user to the port-forwarding "dashboard" when they've added their first port-forward
Screen.Recording.2021-11-05.at.11.05.07.AM.mov
enhances #2340